Add mloiseleur to reviewer group #3700
Conversation
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
|
@Raffo: GitHub didn't allow me to request PR reviews from the following users: for, approval. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Ok, parking this until we can add @mloiseleur to the kubernetes-sigs org. I will spin up a PR for that too. |
|
@mloiseleur can you please create an issue to request your membership to the kubernetes sigs org? You have to do this here: https://github.com/kubernetes/org/issues/new/choose . You can put me and @szuecs as sponsors. |
|
@Raffo here it is: kubernetes/org#4301 |
|
Technically, per https://github.com/kubernetes/community/blob/master/community-membership.md it is a requirement for reviewers to have been a member for at least 3 months. |
| @@ -13,6 +13,7 @@ reviewers: | |||
| - raffo | |||
| - seanmalloy | |||
| - szuecs | |||
| - mloiseleur | |||
There was a problem hiding this comment.
Should this not be in alphabetical order?
There was a problem hiding this comment.
There's no such requirement.
There was a problem hiding this comment.
Generally, when modifying a list that is already in alphabetical order I try to maintain that order.
|
@johngmyers TIL about the 3 months timeline, I wasn't aware of such requirement. We can respect it, it's no big deal, but it's mostly a limitation and not really helping the project. |
|
Another requirement is "Reviewed or merged at least 20 substantial PRs to the codebase." I only see 14 PRs total with a comment. Of those, I could only find one review with feedback. I am very happy for the help and enthusiastically welcome @mloiseleur to membership, but I think reviewer is a bit premature. |
|
Well, we'll park it here until the prerequisite are established then. |
|
/retest |
|
@johngmyers Is there still a prerequisite I should fulfill ? |
|
I believe you become eligible on October 19. |
|
/lgtm |
k8s-ci-robot
added
lgtm
Description
This PR adds
mloiseleurto the reviewer group./cc @szuecs for approval